Fix broken repository URL in package.json#99
Fix broken repository URL in package.json#99juliangruber merged 3 commits intojuliangruber:masterfrom
Conversation
GitHub hasn't supported the git protocol [since 2022](https://github.blog/security/application-security/improving-git-protocol-security-github/#no-more-unauthenticated-git), so this URL is broken. (This is a common error affecting many popular npm packages; I'm opening PRs on several projects to fix it. I encourage anyone reading this to check any packages they maintain and implement the same fix if appropriate!)
|
Can be merged with @ljharb's approval |
|
Does this warrant a new patch level release? |
I probably wouldn't bother with one just for this if I were in your place, to be honest, although given the last release was 6 years ago I do realise that means this may never get released at all. |
|
(Though if I wanted to make the case for doing a patch release just for this, it would be: https://registry.npmjs.org/isarray outputs an outright broken repo URL right now, which is in some sense a bug, so this fix is in some sense a bugfix, and any bugfix, no matter how trivial, is worthy of at least getting released at some point. And if you don't release it now, it may never get released - recent history suggests there may never be any other change on this package in future that warrants a new release.) |
|
correction; it's not broken, if you parse it with https://npmjs.com/hosted-git-info it works fine, and that's the expectation for anything returned from npm in that position :-) |
3 participants
GitHub hasn't supported the git protocol since 2022, so this URL is broken.
(This is a common error affecting many popular npm packages; I'm opening PRs on several projects to fix it. I encourage anyone reading this to check any packages they maintain and implement the same fix if appropriate!)